From dc6c98fdc3dc0dd1698209ce6cb74068a01c4fd1 Mon Sep 17 00:00:00 2001 From: Khushboo <46913995+khushboo9024@users.noreply.github.com> Date: Fri, 10 Mar 2023 11:24:07 +0530 Subject: [PATCH] Fix CloudTrail Control to acknowledge organization-level trails Closes #536 (#552) --- .../cloudtrail_multi_region_trail_enabled.sql | 28 +++++++++++++++---- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/query/cloudtrail/cloudtrail_multi_region_trail_enabled.sql b/query/cloudtrail/cloudtrail_multi_region_trail_enabled.sql index 37b91a6b..0269efcc 100644 --- a/query/cloudtrail/cloudtrail_multi_region_trail_enabled.sql +++ b/query/cloudtrail/cloudtrail_multi_region_trail_enabled.sql @@ -10,17 +10,35 @@ with multi_region_trails as ( group by account_id, is_multi_region_trail +), organization_trails as ( + select + is_organization_trail, + is_logging, + is_multi_region_trail, + account_id + from + aws_cloudtrail_trail + where + is_organization_trail ) select -- Required Columns - a.arn as resource, + distinct a.arn as resource, case - when coalesce(num_multregion_trails, 0) < 1 then 'alarm' - else 'ok' + when coalesce(num_multregion_trails, 0) >= 1 then 'ok' + when o.is_organization_trail and o.is_logging and o.is_multi_region_trail then 'ok' + when o.is_organization_trail and o.is_multi_region_trail and o.is_logging is null then 'info' + else 'alarm' end as status, - a.title || ' has ' || coalesce(num_multregion_trails, 0) || ' multi-region trail(s).' as reason, + case + when coalesce(num_multregion_trails, 0) >= 1 then a.title || ' has ' || coalesce(num_multregion_trails, 0) || ' multi-region trail(s).' + when o.is_organization_trail and o.is_logging and o.is_multi_region_trail then a.title || ' has multi-region trail(s).' + when o.is_organization_trail and o.is_multi_region_trail and o.is_logging is null then a.title || ' has organization trail, check organization account for cloudtrail logging status.' + else a.title || ' does not have multi-region trail(s).' + end as reason, -- Additional Dimensions a.account_id from aws_account as a -left join multi_region_trails as b on a.account_id = b.account_id; \ No newline at end of file + left join multi_region_trails as b on a.account_id = b.account_id + left join organization_trails as o on a.account_id = o.account_id \ No newline at end of file