Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query config_enabled_all_regions should check all regions even if connections don't include all regions #27

Closed
cbruno10 opened this issue May 22, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@cbruno10
Copy link
Contributor

Describe the bug
This query will not properly report if a configuration recorder is enabled in a region, as it will always report alarm even if a configuration recorder is setup correctly in that region, if the region is not included in the aws.spc connection file.

Steampipe version (steampipe -v)
v0.5.0

Plugin version (steampipe plugin list)
aws v0.18.0

To reproduce

  • Create a configuration recorder in us-west-1 and configure it so:
    recording_group -> 'IncludeGlobalResourceTypes' = 'true'
    and recording_group -> 'AllSupported' = 'true'
    and status ->> 'Recording' = 'true'
    and status ->> 'LastStatus' = 'SUCCESS'
    
  • Do not include us-west-1 in the regions argument in aws.spc
  • Run the query

Expected behavior
The query should return ok instead of alarm

Additional context
Add any other context about the problem here.

@cbruno10 cbruno10 added the bug Something isn't working label May 22, 2021
@cbruno10 cbruno10 self-assigned this May 22, 2021
@LalitLab
Copy link

@LalitLab
Copy link

There is a way to get it working but in that case, we have to change the table design to get the details of the configuration recorder for each enabled region.
It will be a simple change to include the parent hydrate function listAwsRegions to get the details of every region

similar to aws_ec2_instance_availability

@cbruno10
Copy link
Contributor Author

I believe with connection tables, we could skip regions we aren't checking and inform the users properly - requested in turbot/steampipe#505

@misraved
Copy link
Contributor

Closing this since the implementation was done here - turbot/steampipe#505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants