Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to connect through proxy #6

Closed
tonibony opened this issue Dec 3, 2020 · 10 comments
Closed

Add ability to connect through proxy #6

tonibony opened this issue Dec 3, 2020 · 10 comments
Labels
enhancement New feature or request
Milestone

Comments

@tonibony
Copy link

tonibony commented Dec 3, 2020

I installed this app on a Windows system, which connects to Internet only through http proxy. The proxy settings are configured at system level. When I start the app configurator, an error box pop-ups, saying "Unable to get list of AdoptOpenJDK releases". Using the web browser, I can access https://api.adoptopenjdk.net/v3/info/available_releases and I see the result (a JSON document). Also, I don't see any hint in the app configuration UI and documentation about using a proxy.

I will be pleased if there is a way to use the app with at least http proxy.

@pjhavariotis
Copy link

I installed this app on a Windows system, which connects to Internet only through http proxy. The proxy settings are configured at system level. When I start the app configurator, an error box pop-ups, saying "Unable to get list of AdoptOpenJDK releases". Using the web browser, I can access https://api.adoptopenjdk.net/v3/info/available_releases and I see the result (a JSON document). Also, I don't see any hint in the app configuration UI and documentation about using a proxy.

I will be pleased if there is a way to use the app with at least http proxy.

Well said @tonibony ! Proxy support is a must for such software!

@tushev
Copy link
Owner

tushev commented Dec 4, 2020

Hello, thank you for your feedback. Yes, proxy is not supported currently.

I think I will add proxy support in the next release (2.0.2).

However, there is no release date yet.

@tushev tushev added the enhancement New feature or request label Dec 4, 2020
@tushev tushev added this to the 2.0.2 milestone Dec 4, 2020
@tushev
Copy link
Owner

tushev commented Dec 7, 2020

@tonibony @pjhavariotis

I need your help. I've added support for Windows default proxy (Win+R: ms-settings:network-proxy), so the updater will reuse global configuration. However, I don't have a proxy, so, please test the following pre-release https://github.com/tushev/aojdk-updatewatcher/releases/tag/2.0.1.1
and tell me whether it works or not in real scenarios.

Preferred - backup the existing C:\Program Files\AJUpdateWatcher dir and just overwrite its contents from the ZIP, restore back once tested.

@pjhavariotis
Copy link

I have just tested the pre-release and it seems is working! To be specific, I executed the "Run immediate checks for updates" command, and after a while the screen showed up with the corresponding updates! Finally, I updated my JDK with the latest version without any issue!

@tushev
Copy link
Owner

tushev commented Dec 8, 2020

@pjhavariotis great! I will include this functionality in the next release then. The release, however, may take a bit longer as there are some other things to implement...

@tonibony
Copy link
Author

tonibony commented Dec 8, 2020

Yep, it's working in my case too! I've tested showing the configuration dialog and the "Check for AdoptOpenJDK updates" button on it.

@tushev
Copy link
Owner

tushev commented Dec 9, 2020

@tonibony Great, thanks!

The only untested item left is self-update - once v. 2.0.2 will be released publicly, your updaters should pick it. However, self-update uses exactly the same code, so it should be working as well.

@tushev
Copy link
Owner

tushev commented Dec 29, 2020

Released https://github.com/tushev/aojdk-updatewatcher/releases/tag/2.0.2.0

Your pre-release version should pick it up automatically, please confirm.

@tushev tushev closed this as completed Dec 29, 2020
@pjhavariotis
Copy link

Confirmed !
Happy New Year !
Be Safe !

@tushev
Copy link
Owner

tushev commented Jan 4, 2021

@pjhavariotis Thank you, you too! Happy New Year!! 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants