Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base62 is actually Base61 #22

Closed
johnaoss opened this issue Apr 6, 2020 · 2 comments
Closed

Base62 is actually Base61 #22

johnaoss opened this issue Apr 6, 2020 · 2 comments

Comments

@johnaoss
Copy link

johnaoss commented Apr 6, 2020

The character set provided in the spec:

0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxy

Only contains 61 characters, and is thus a base61 encoding. Looking at the implementations listed on the document, it seems that most of them (if not all) include a z to the character set as I would expect.

Is this the intended behaviour? Or should the character set not include the character z?

@tuupola
Copy link
Owner

tuupola commented Apr 12, 2020

You are correct. Seems to be copy paste error. The z is missing. It should be 0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz.

@tuupola
Copy link
Owner

tuupola commented Apr 12, 2020

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants