Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psr/http-message 2.x support #88

Open
jankonas opened this issue Jun 8, 2024 · 2 comments
Open

psr/http-message 2.x support #88

jankonas opened this issue Jun 8, 2024 · 2 comments
Assignees

Comments

@jankonas
Copy link
Contributor

jankonas commented Jun 8, 2024

I would like to use this package with psr/http-message v 2.x. I could easily provide PR with update to composer.json to allow it, but there is a problem with neomerx/cors-psr7 which seems to be no longer maintained.

In my projects i use my fork which replaces the original package, so adding |^2.0 to composer.json would be enough for me, but keeping the neomerx/cors-psr7 dependency would mean that this package will be never tested against psr/http-message v 2.x.

What are your thoughts about this package future? Are you willing switch to some neomerx/cors-psr7 fork or fork it yourself?

@tuupola tuupola self-assigned this Jun 9, 2024
@tuupola
Copy link
Owner

tuupola commented Jun 9, 2024

I am currently doing more Kubernetes stuff than programming so I do not want to maintain any new libraries. But if neomerx/cors-psr7 is dead and someone (you) are willing to start maintaining a fork, I am ok switching to it.

@jankonas
Copy link
Contributor Author

jankonas commented Jun 23, 2024

Thank for the reply. I created an issue in the neomerx/cors-psr7 repository.

As for maintaining my fork, I have no problem with that, I would just have to sort out some infrastructure stuff (for now it's just a mirror from a private Gitlab repository) to ease accepting the PRs and issues.

In the meantime, I submitted #90, feel free to close it if you don't want an untestable stuff in your repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants