Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate media-queries from docs into core #1365

Closed
mahemoff opened this issue Jan 29, 2012 · 1 comment
Closed

Incorporate media-queries from docs into core #1365

mahemoff opened this issue Jan 29, 2012 · 1 comment

Comments

@mahemoff
Copy link

I think some of the media queries in docs.css really be ought to be standard in every project, ie moved to the core. Specific examples.

Snippet 1

@media (min-width: 940px) {
  .nav-collapse.collapse {
    height: auto !important;
  }
}

Took me a while to figure out what was going on here. I collapsed the nav while in <940px (ie while the collapse toggle is visible), then extended the width and found the entire nav disappeared altogether! That's because .collapse has overflow: hidden set when collapsed, hence need height: auto as in the docs.

Snippet 2

@media (max-width: 768px) {
  body {
    padding-top: 0;
  }
}

Without this, I had a gap between the top of the page and the navbar (at <768px resolution), as I had a padding-top set for body (as in the nav).

Snippet 3?

This possibly applies to other media queries in the docs, particularly subnav-related. I haven't used subnav, so not sure.

@mdo
Copy link
Member

mdo commented Jan 29, 2012

Just added #1 to the main responsive file.

#2 is already in the responsive.less file, but targeted for max-width: 940px;.

The subnav is not part of the 2.0 release—we'll circle back around to that later.

Good feedback!

@mdo mdo closed this as completed Jan 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants