-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actual help texts are rendered as error, warning, success etc. #1939
Comments
I clarified text and improved my suggestion #2. |
I am very much in favor of having this addressed, as it seem like an oversight to not handle the original help-texts when adding error/success messages. I personally am in favor of @dyve's #1 above, as there is a semantic difference between help text for a field and status messages about the entry/submission. +1 |
why dont you guys just make your own class in your less files, .message-block { The point here being, its too easy to see bootstrap as set in stone, but its so easy to customize for own needs. Think outside of the box. |
@andriljas, something like what you propose is what I'm doing right now. But, I see it as an area of form rendering that bootstrap should cover by default. |
you could use tooltips for actual help text and help-inline for errors, example: #2161 |
What I would like to highlight as an issue though is the fact that you cant put an input into "error state" unless you have the control group markup in place. But Im not sure its something bootstrap should solve out of the box. |
When a form is styled with form control states (http://twitter.github.com/bootstrap/base-css.html?#forms, scroll down a little), all help texts (both help-inline and help-block) take their styling from the control state (error, warning, etc).
However, the example fails to take regular help text into account.
With the current version of Bootstrap, any help text within a control-group with a state class is styled as if it is part of the error message, which is wrong. The help text should be styled as what it is, a help text. The underlying issue here of course is that the messages are using the classes for help.
I made a small demo of the official Bootstrap example with added help-block p's with regular help text. I hope this illustrates the problem:
http://jsfiddle.net/TE7HK/1/ (same goes for help-inline)
I see two possible solutions.
e.g.
After writing this up, I'm in favor of solution #2.
The text was updated successfully, but these errors were encountered: