Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.badge class name conflicting with original .badge class name #21150

Closed
guylepage3 opened this issue Nov 16, 2016 · 3 comments
Closed

.badge class name conflicting with original .badge class name #21150

guylepage3 opened this issue Nov 16, 2016 · 3 comments

Comments

@guylepage3
Copy link

So there seems to be some confusion between .label, .tag, .badge

Back in issue #19094, we determined that there was a conflict between the class name .label and the html tag <label>. As a result, we changed .label to .tag in issue #19157. .tag was then determined to conflict with Wordpress. See issue #20542. .tag was then proposed to be changed to .badge #21020.

New Issue:
.badge is already a class name within Bootstrap and will conflict with the current .badge class name. See http://getbootstrap.com/components/#badges.

Proposal:
Reconsider the merge "Renamed .tag back to .badge, like v3, to avoid conflicts with common WordPress styles." in the v4 Alpha 6 ship list and change the new .badge, originally .label.tag, to one of the following options:

  • .stamp
  • .signet
@wolfy1339
Copy link
Contributor

v3 and v4 are incompatible... They can basically take any class they want and completely change them without any consequences as this is a major release.

@guylepage3
Copy link
Author

guylepage3 commented Nov 16, 2016

@wolfy1339 So .badge is deprecated from v4 then?

@guylepage3
Copy link
Author

guylepage3 commented Nov 16, 2016

Nevermind. please close this issue.

class names have add on -pill, seen here in documentation, that resolves this issue and should be renamed to .badge. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants