Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popper fallback leads to worse layouting #32506

Closed
septatrix opened this issue Dec 16, 2020 · 9 comments
Closed

Popper fallback leads to worse layouting #32506

septatrix opened this issue Dec 16, 2020 · 9 comments

Comments

@septatrix
Copy link
Contributor

Commit f132400 introduced a regression (or at least I would classify it as such).
Dropdowns close to the right screen edge overflow instead of being show the the left.
I simply used a textarea and the example code from the docs with an inline utility class.
This allows me to simple move the button to the right edge.

The following screenshots show the behaviour (with the black area being the devtools).

Dropdown not shown
Screenshot from 2020-12-16 15-50-49

Dropdown behaviour after the commit.
Screenshot from 2020-12-16 15-50-54

Dropdown behaviour before the commit.
Screenshot from 2020-12-16 15-52-11


  • Operating system and version: Linux - Ubuntu 20.10
  • Browser and version: Chrome 87

I am unable to give an example to reproduce as the changed code is not yet in a release (and I currently do not have the time to compile and self-host).

@XhmikosR
Copy link
Member

Should be fixed by #32437 already, /CC @rohit2sharma95

@rohit2sharma95
Copy link
Collaborator

@septatrix can you please create a reduced test case via CodePen or JS Bin 🙂
@XhmikosR That PR is just for Tooltip/Popover and updates the docs and default value. Although, default fallback placement has been changed in dropdown also and should be mentioned in the docs.

@XhmikosR
Copy link
Member

Oh, indeed. Can you make a PR referencing the PR that changed it and adapting the docs later please?

@septatrix
Copy link
Contributor Author

Test: https://jsbin.com/nabugatehu/edit?html,output (Output panel was set to 1200px width)

As explained earlier I had to compile the current state of the main branch as it is not in npm yet.
To switch between the beta-1 release and the current state of main (which still has the regression) toggle the comments in the header.
The referenced files were generated by running npm run dist and uploaded to a fork.

@ghost
Copy link

ghost commented Dec 17, 2020

Happens to me too.

@ghost
Copy link

ghost commented Dec 17, 2020

You could try the float : left; in CSS with the class to fix the issue @septatrix

@septatrix
Copy link
Contributor Author

Disabling right: auto!important; for .dropdown-menu[style] seems to fix the issue partially. It leads to a better result than currently but still worse than beta-1 IMO.

@rohit2sharma95 rohit2sharma95 mentioned this issue Dec 21, 2020
4 tasks
@septatrix
Copy link
Contributor Author

Disabling right: auto!important; for .dropdown-menu[style] seems to fix the issue partially. It leads to a better result than currently but still worse than beta-1 IMO.

This is also a suggested fix for #32484

@rohit2sharma95
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants