Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created offcanvas component for navbar collapse example #33531

Closed
crftwrk opened this issue Mar 31, 2021 · 3 comments
Closed

Created offcanvas component for navbar collapse example #33531

crftwrk opened this issue Mar 31, 2021 · 3 comments

Comments

@crftwrk
Copy link
Contributor

crftwrk commented Mar 31, 2021

Hello,

the new offcanvas is a stand-alone component, but it should be able to display collapsed navbar as well. Created a navbar example which shows menu <992px (class navbar-expand-lg) in offcanvas component instead of the top open default navbar. navbar-expand{-sm|-md|-lg|-xl|-xxl} class can be used to set the breakpoints.

Demo: https://examples.bootscore.me/bootstrap-offcanvas-navbar/
Code: https://github.com/craftwerkberlin/bootstrap-offcanvas-navbar

@crftwrk crftwrk changed the title Offcanvas component for navbar collapse Offcanvas component for navbar collapse example Mar 31, 2021
@crftwrk crftwrk changed the title Offcanvas component for navbar collapse example Created offcanvas component for navbar collapse example Mar 31, 2021
@devhoussam
Copy link
Contributor

I take a look to preview example it look like a good idea try to create a pull request.

@mdo
Copy link
Member

mdo commented Mar 31, 2021

@craftwerkberlin If you want to submit this in a PR, we'd gladly review! This was on our list to follow-up with already, so love that someone's already taken a stab at it. Would love to see it added to the navbar/offcanvas docs, and maybe in a new example that builds on what you've built here.

@crftwrk
Copy link
Contributor Author

crftwrk commented Apr 1, 2021

@devhoussam @mdo I created a PR #33537, so this Issue can be closed.

Thank you

@crftwrk crftwrk closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants