Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input group right validation border with button addon #37058

Closed
3 tasks done
florianlacreuse opened this issue Aug 30, 2022 · 0 comments · Fixed by #37059
Closed
3 tasks done

Input group right validation border with button addon #37058

florianlacreuse opened this issue Aug 30, 2022 · 0 comments · Fixed by #37059

Comments

@florianlacreuse
Copy link
Contributor

florianlacreuse commented Aug 30, 2022

Prerequisites

Describe the issue

In the current snapshot version (to be released), the right border of a validated input is not visible:

<div class="input-group has-validation">
  <span class="input-group-text">@</span>
  <div class="form-floating is-invalid">
    <input type="text" class="form-control is-invalid" id="floatingInputGroup2" placeholder="Username" required="">
    <label for="floatingInputGroup2">Username</label>
  </div>
  <button type="button" class="btn btn-outline-secondary">Button</button>
  <div class="invalid-feedback">
    Please choose a username.
  </div>
</div>

Capture

(same thing with classic .form-control elements, it's not just with .form-floating inputs)

Last year the same issue #33204 had been fixed with PR #33211.

I don't know what happen since, but the right border is broken again.

Reduced test cases

https://codepen.io/florianlacreuse/pen/eYrOZEb

What operating system(s) are you seeing the problem on?

Windows, Linux

What browser(s) are you seeing the problem on?

Chrome, Firefox

What version of Bootstrap are you using?

5.2.0+

@julien-deramond julien-deramond moved this to Todo in v5.2.1 Aug 31, 2022
@julien-deramond julien-deramond moved this from Todo to Needs review in v5.2.1 Aug 31, 2022
@mdo mdo closed this as completed in #37059 Sep 1, 2022
Repository owner moved this from Needs review to Done in v5.2.1 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants