Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled form-floating input uses wrong colour #37362

Closed
3 tasks done
lonix1 opened this issue Oct 24, 2022 · 2 comments · Fixed by #37408
Closed
3 tasks done

Disabled form-floating input uses wrong colour #37362

lonix1 opened this issue Oct 24, 2022 · 2 comments · Fixed by #37408
Labels

Comments

@lonix1
Copy link

lonix1 commented Oct 24, 2022

Prerequisites

Describe the issue

A disabled form-floating input uses the wrong colour.

Reduced test cases

Demo shows:

  • disabled input in grey - correct
  • disabled form-floating input in black - incorrect

https://codepen.io/vwhzvdkyrlmuapzyih/pen/MWXgVmm

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

Firefox

What version of Bootstrap are you using?

5.2.2

@julien-deramond
Copy link
Member

By adding the following code to the ongoing PR (#37299) about floating labels:

> .form-control:disabled ~ label {
    color: $form-floating-disabled-color;
}

we'd get this rendering:

Screenshot 2022-10-25 at 07 49 11

For the select, it seems to be consistent with Select > Disabled.

For the floating labels (without values), if we do that, don't we confuse a disabled floating label (that displays only the label) with a disabled input?

@mdo Thoughts?

If this modification is OK, I can add it in my PR.

@mdo
Copy link
Member

mdo commented Oct 31, 2022

I think we do risk that, but generally that's okay I think as the end result is the same—an input with a label is disabled. I merged your other PR without seeing this—want to cut a new one if you're able?

@julien-deramond julien-deramond moved this from To do to Needs review in v5.3.0 Oct 31, 2022
Repository owner moved this from Needs review to Done in v5.3.0 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants