Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$navbar-dark-icon-color missing? #38671

Closed
3 tasks done
endcoreAK opened this issue May 30, 2023 · 1 comment · Fixed by #38673
Closed
3 tasks done

$navbar-dark-icon-color missing? #38671

endcoreAK opened this issue May 30, 2023 · 1 comment · Fixed by #38673

Comments

@endcoreAK
Copy link

Prerequisites

Describe the issue

There is a variable for $navbar-light-icon-color but not $navbar-dark-icon-color is that the way it's supposed to be?

Reduced test cases

https://github.com/twbs/bootstrap/blob/main/scss/_variables.scss#L1209

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

5.3.0-alpha3

@julien-deramond
Copy link
Member

There is a variable for $navbar-light-icon-color but not $navbar-dark-icon-color is that the way it's supposed to be?

For consistency, I think $navbar-dark-icon-color should be introduced as a new variable. It's handled in #38673. Thanks for reporting this issue @endcoreAK!

@mdo mdo added this to v5.3.1 May 30, 2023
@julien-deramond julien-deramond moved this to Ready to merge in v5.3.1 May 31, 2023
@mdo mdo closed this as completed in #38673 Jun 1, 2023
@mdo mdo moved this from Ready to merge to Done in v5.3.1 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants