Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltips/popovers should choose a different placement instead of running off the page #5032

Closed
ianstormtaylor opened this issue Sep 7, 2012 · 11 comments
Labels

Comments

@ianstormtaylor
Copy link

two ways this could be done:

  1. just straight up change the placement if the tooltip is going to run off.
  2. instead of changing the placement, move the tooltip to stay inside the window. but then also position the tooltip arrow to make sure that it is still centered above the element.
@vitalets
Copy link

vitalets commented Sep 8, 2012

do you mean the same as #4687 ?

@ianstormtaylor
Copy link
Author

yeah solution #1 would be the same

@andrewdeandrade
Copy link

Hey @ianstormtaylor,

Thanks for opening this issue! Unfortunately, it looks like it fails to pass the criteria neccessary for submitting to bootstrap. The following things are currently failing:

  • should include a jsfiddle/jsbin illustrating the problem if tagged with js but not a feature

For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines.

thanks!

@ianstormtaylor
Copy link
Author

figured it was only a matter of time before the dumb logic in those messages came around. there's no need for a jsfiddle in this issue because it's a feature suggestion

@asleepysamurai
Copy link

Is this an accepted feature request? Because, I recently implemented this functionality and I can submit a pull request if this is accepted.

@jbrodie
Copy link

jbrodie commented Oct 23, 2012

This is something that should be added to the bootstrap for sure. We currently have the exact same problem with placements now.

@vikasaditya
Copy link

@asleepysamurai why don't you just submit a pull request and mention it here? Would be helpful to many who need this basic functionality.

@Yohn
Copy link
Contributor

Yohn commented Oct 25, 2012

👍 id try to submit a pull request and see what happens

@asleepysamurai
Copy link

Ah, but adding a pull request for such a popular project without knowing if it is required just adds to the workload of the maintainers right??? Anyway, for those who need this, this is my modified tooltip plugin: https://gist.github.com/3972145

If, this feature request is accepted, i'll take some time out to test this a bit more thoroughly and then submit a pull request. Cheers!

@mdo
Copy link
Member

mdo commented Dec 28, 2012

Closing as a dupe issue—just saw this earlier today after reading through the issues.

@mdo mdo closed this as completed Dec 28, 2012
@archonic
Copy link

I'd start a new issue but it's heavily related to this one. The dynamic placement is screwing things up for me.
badbadverybad

Is there a way to get it to pop up inside the parent div automatically? For below I used chrome dev tools to adjust the margin but saving this change and refreshing just has the automatic placement re-accommodate and appear in the same place (like above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants