You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that adding a new prototype method to Modal to deal with special exceptions for enforceFocus would be handy in avoiding situations like zeroclipboard/zeroclipboard#159.
jQuery UI has a similar extension point for their modal dialog, called _allowInteraction; see zeroclipboard/zeroclipboard#179.
The text was updated successfully, but these errors were encountered:
It's a legit fix, yeah. My concern is that fully overriding the method might lead to unexpected issues when a consumer upgrades their Bootstrap version, i.e. if that method changes in later versions to fix a bug or something. Obviously the consumer can just update their prototype override but that wouldn't even be necessary if there was a more granular extension point specifically just for allowing interaction exceptions.
If you think it's too much of an edge case, that's cool. However, the existence of that same extension point in jQuery UI makes me suspect it's come up more than a few times before.
hm… i think for now that your solution as is makes the most sense. It's not so much that it's a rare edge case, as that's how i really want people to be extending the plugins.
It seems that adding a new prototype method to Modal to deal with special exceptions for
enforceFocus
would be handy in avoiding situations like zeroclipboard/zeroclipboard#159.jQuery UI has a similar extension point for their modal dialog, called
_allowInteraction
; see zeroclipboard/zeroclipboard#179.The text was updated successfully, but these errors were encountered: