From 9664f8da58abe718463ee31398e5d15de37f7289 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 9 Dec 2013 15:59:50 -0800 Subject: [PATCH 1/2] add parens around arithmetic in recursive mixin calls to comply with LESS strictMath <3 @seven-phases-max for helping to confirm & debug this X-Ref: https://github.com/less/less.js/issues/1725 --- less/mixins.less | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/less/mixins.less b/less/mixins.less index c107b566e1b9..b5beaddf283e 100644 --- a/less/mixins.less +++ b/less/mixins.less @@ -729,11 +729,11 @@ // Common styles for all sizes of grid columns, widths 1-12 .col(@index) when (@index = 1) { // initial @item: ~".col-xs-@{index}, .col-sm-@{index}, .col-md-@{index}, .col-lg-@{index}"; - .col(@index + 1, @item); + .col((@index + 1), @item); } .col(@index, @list) when (@index =< @grid-columns) { // general; "=<" isn't a typo @item: ~".col-xs-@{index}, .col-sm-@{index}, .col-md-@{index}, .col-lg-@{index}"; - .col(@index + 1, ~"@{list}, @{item}"); + .col((@index + 1), ~"@{list}, @{item}"); } .col(@index, @list) when (@index > @grid-columns) { // terminal @{list} { @@ -751,11 +751,11 @@ .make-grid-columns-float(@class) { .col(@index) when (@index = 1) { // initial @item: ~".col-@{class}-@{index}"; - .col(@index + 1, @item); + .col((@index + 1), @item); } .col(@index, @list) when (@index =< @grid-columns) { // general @item: ~".col-@{class}-@{index}"; - .col(@index + 1, ~"@{list}, @{item}"); + .col((@index + 1), ~"@{list}, @{item}"); } .col(@index, @list) when (@index > @grid-columns) { // terminal @{list} { @@ -790,7 +790,7 @@ .make-grid(@index, @class, @type) when (@index >= 0) { .calc-grid(@index, @class, @type); // next iteration - .make-grid(@index - 1, @class, @type); + .make-grid((@index - 1), @class, @type); } From ab29b1a3352e89fe8756a34e49a38341edd06844 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 9 Dec 2013 16:12:41 -0800 Subject: [PATCH 2/2] misc strictMath compliance fixes --- less/dropdowns.less | 2 +- less/forms.less | 2 +- less/panels.less | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/less/dropdowns.less b/less/dropdowns.less index 1a8f1973f418..4bdc223fcecb 100644 --- a/less/dropdowns.less +++ b/less/dropdowns.less @@ -142,7 +142,7 @@ right: 0; bottom: 0; top: 0; - z-index: @zindex-dropdown - 10; + z-index: (@zindex-dropdown - 10); } // Right aligned dropdowns diff --git a/less/forms.less b/less/forms.less index 50df399e324f..f7fc5d66c8cc 100644 --- a/less/forms.less +++ b/less/forms.less @@ -352,7 +352,7 @@ input[type="checkbox"], // and other content below items .radio, .checkbox { - min-height: @line-height-computed + (@padding-base-vertical + 1); + min-height: (@line-height-computed + (@padding-base-vertical + 1)); } // Make form groups behave like rows diff --git a/less/panels.less b/less/panels.less index 37ab67043638..a6b723c68cef 100644 --- a/less/panels.less +++ b/less/panels.less @@ -102,7 +102,7 @@ .panel-heading { padding: 10px 15px; border-bottom: 1px solid transparent; - .border-top-radius(@panel-border-radius - 1); + .border-top-radius((@panel-border-radius - 1)); > .dropdown .dropdown-toggle { color: inherit; @@ -126,7 +126,7 @@ padding: 10px 15px; background-color: @panel-footer-bg; border-top: 1px solid @panel-inner-border; - .border-bottom-radius(@panel-border-radius - 1); + .border-bottom-radius((@panel-border-radius - 1)); }