Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport JS unit test fixes from v4 #20259

Merged
merged 2 commits into from
Jul 8, 2016
Merged

Backport JS unit test fixes from v4 #20259

merged 2 commits into from
Jul 8, 2016

Commits on Jul 8, 2016

  1. Port #20190 to v3 

    Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182

Instead of doing a new assert.async(), just do a single one for the entire test
and let the .then() be async as well.
    @dmethvin @cvrebert
    dmethvin authored and cvrebert committed Jul 8, 2016
    Configuration menu
    Copy the full SHA
    4a8b29f View commit details
    Browse the repository at this point in the history

  2. Port #20198 to v3 

    ScrollSpy unit test: Use single done() in a then() instead of multiple done()s

Fixes test flakiness on OS X Safari and Android when using jQuery 3.
Fixes #20182 more
Refs #20191
    @dmethvin @cvrebert
    dmethvin authored and cvrebert committed Jul 8, 2016
    Configuration menu
    Copy the full SHA
    bc05ef1 View commit details
    Browse the repository at this point in the history