Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply consistent layout to type constructors in signatures #427

Closed
neongreen opened this issue Oct 29, 2019 · 2 comments · Fixed by #539
Closed

Apply consistent layout to type constructors in signatures #427

neongreen opened this issue Oct 29, 2019 · 2 comments · Fixed by #539
Assignees
Labels
style Nitpicking and things related to purely visual aspect for formatting.

Comments

@neongreen
Copy link
Collaborator

neongreen commented Oct 29, 2019

Input:

f :: forall x y.
      D x y x y

Output:

f ::
  forall x y.
  D x y x
    y

While I'm at it, this should also probably be consistent with data declarations?

Input:

data D = forall x y.
         D x y x y

Output:

data D
  = forall x y.
    D
      x
      y
      x
      y

My preferred option in both cases would be:

f ::
  forall x y.
  D x y x y

data D
  = forall x y.
    D x y x y
@neongreen neongreen added the style Nitpicking and things related to purely visual aspect for formatting. label Oct 29, 2019
@mrkkrp
Copy link
Member

mrkkrp commented Oct 29, 2019

What do you mean "while I'm at it"? If you are referring to your current work on #423, then please introduce as few changes as possible and then when it's merged we can return to this one and do it in a separate PR.

Otherwise, yes, I agree that these changes make sense.

@neongreen
Copy link
Collaborator Author

"while I'm at it" means "while I'm talking about things that have D x y x y in them". Sorry for confusing you.

I'm not going to make this change in #423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style Nitpicking and things related to purely visual aspect for formatting.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants