Buildifier fix #1908
Merged
Buildifier fix #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reactivates the buildifier tests in the CI and fixes some errors in the buildifier setup.
I had set the buildifier targets to manual locally because buildifier does not work yet with bzlmod on NixOS (bzlmod: Reuse user-defined Go SDK for Gazelle bootstrap bazel-contrib/bazel-gazelle#1469) and accidentally committed the change.
The nix setup in the CI was failing because of the following issue (for instance here) so the install-nix-action was updated to 22.