Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests-audio makefile issue (minor) #47

Open
twiddlingbits opened this issue Sep 29, 2024 · 5 comments
Open

tests-audio makefile issue (minor) #47

twiddlingbits opened this issue Sep 29, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@twiddlingbits
Copy link
Owner

should the .o files go into out vs. example root?

@twiddlingbits twiddlingbits added the bug Something isn't working label Sep 29, 2024
@twiddlingbits
Copy link
Owner Author

twiddlingbits commented Sep 29, 2024

also is this line needed in pong makefile?
rm -f *.o

@JohnDog3112
Copy link
Collaborator

  1. Maybe? For single file projects (like tests-audio) I've been putting them in root since it doesn't cause that much clutter. It seems you might have done something similar for test-users, tests, terminal, multi-io, maze, and several others. I can switch it to go to an out folder though.

  2. rm -f *.o was originally in Pong because the original, single player, pong only had one file and simply dumped the .o files in the root rather than an out folder. I guess I forgot to delete it when I made the change.

@twiddlingbits
Copy link
Owner Author

twiddlingbits commented Oct 2, 2024

I think it's fine for smaller projects to put the .o files in the project root.

in some examples that had more files, i started to use an out folder for the build artifacts. I think we (or at least me) have been inconsistent in the use of an out folders. For example, we have: .o files, .js files, .wasm files. Some are temporary, some are needed to execute the final build. For the ones that need to execute the final build, i try to check them in to main (so that examples can be run. ). But i doubt i/we have been consistant on that. Currently we are committing some out/.js and some .wasm (not in out) to main. We should probably clean up all the examples to be consistent. There are various options, but I think probably the best is to put all build artifacts needed to run the example (.wasm, .js) into the example root, and all the temp build artifacts into out (and then out can not be committed to main).

What do you think?

@JohnDog3112
Copy link
Collaborator

That sounds good. Though, I feel like out should be called build instead. Out makes me thing "output" which would be better suited for the .wasm and .js files. Meanwhile something like "build" makes more sense for build artifacts and other temporary files.

@twiddlingbits
Copy link
Owner Author

My friend ChatGPT say: https://chatgpt.com/c/66fefe05-d62c-800a-89bf-67886fbf187f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants