Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'This' is out of context when functions are called from view #447

Closed
Ksmike opened this issue Feb 9, 2017 · 2 comments
Closed

'This' is out of context when functions are called from view #447

Ksmike opened this issue Feb 9, 2017 · 2 comments

Comments

@Ksmike
Copy link
Contributor

Ksmike commented Feb 9, 2017 •
edited
Loading

Twig is mismanaging the context of 'this' when making function calls from the view.

For further reference I noticed this when upgrading from v0.8.9 to v0.10.3, but breaking change was introduced in v0.9.1

Added failing test and performed pull request
#448
@Ksmike Ksmike mentioned this issue Feb 9, 2017
Merged
@ghost
Copy link

ghost commented Feb 25, 2017 •
edited by ghost
Loading

Probably a duplicate of #440. But your PR should definitely be used to improve the tests suite.

@ericmorand
Copy link
Contributor

@Ksmike could you please check of this issue is fixed with latest twig.js release?

@willrowe willrowe closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ericmorand @willrowe @Ksmike