You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
League CommonMark: v1.6.6
Twig Markdown-Extra: v3.3.3
Twig: v3.3.3
The LeagueMarkdown constructor is requiring the $converter parameter to explicitly be an instance of CommonMarkConverter, however with League CommonMark v1.6, the converter looks to have been split into two different instance types:
MarkdownConverter
CommonMarkConverter which extends MarkdownConverter
For our usage, we're needing to pass-in the $environment to the converter (GitHub flavor with some other slight modifications) So, with v1.6, we can't use CommonMarkConverter since it triggers a deprecation error:
League CommonMark: v1.6.6
Twig Markdown-Extra: v3.3.3
Twig: v3.3.3
The
LeagueMarkdown
constructor is requiring the$converter
parameter to explicitly be an instance ofCommonMarkConverter
, however with League CommonMark v1.6, the converter looks to have been split into two different instance types:MarkdownConverter
CommonMarkConverter
which extendsMarkdownConverter
For our usage, we're needing to pass-in the
$environment
to the converter (GitHub flavor with some other slight modifications) So, with v1.6, we can't useCommonMarkConverter
since it triggers a deprecation error:Would it be possible to change the constructor for
LeagueMarkdown
to only requireMarkdownConverter
or maybe even just theConverterInterface
?The text was updated successfully, but these errors were encountered: