Fully support guild audit logs #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fully support audit logs by creating types for Audit Log Changes and updating Audit Log Change Keys with new variants. Changes were generic `serde_value::Value`s, which provide no typed information. There are now variants with typed `new` and `old` values - checked against the API - which may or may not both always be present, or never. The `twilight_model::guild::audit_log` module is now entirely documented and tested as well. This has been manually tested by creating as many different audit log changes as could be created in the API and then deserializing the past 100 entries. Closes #77. Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
zeylahellyer
added
t-feature
Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
7596ff
approved these changes
Jul 11, 2021
tbnritzdoge
approved these changes
Jul 12, 2021
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Jul 25, 2021
Fully support audit logs by creating types for Audit Log Changes and updating Audit Log Change Keys with new variants. Changes were generic `serde_value::Value`s, which provide no typed information. There are now variants with typed `new` and `old` values - checked against the API - which may or may not both always be present, or never. The `twilight_model::guild::audit_log` module is now entirely documented and tested as well. This has been manually tested by creating as many different audit log changes as could be created in the API and then deserializing the past 100 entries. Closes twilight-rs#77. Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Jul 31, 2021
Fully support audit logs by creating types for Audit Log Changes and updating Audit Log Change Keys with new variants. Changes were generic `serde_value::Value`s, which provide no typed information. There are now variants with typed `new` and `old` values - checked against the API - which may or may not both always be present, or never. The `twilight_model::guild::audit_log` module is now entirely documented and tested as well. This has been manually tested by creating as many different audit log changes as could be created in the API and then deserializing the past 100 entries. Closes twilight-rs#77. Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
7596ff
added a commit
that referenced
this pull request
Jul 31, 2021
Enhancements Fully support audit logs by creating types for Audit Log Changes and updating Audit Log Change Keys with new variants. Changes were generic `serde_value::Value`s, which provide no typed information. There are now variants with typed `new` and `old` values - checked against the API - which may or may not both always be present, or never. The `twilight_model::guild::audit_log` module is now entirely documented and tested as well. This has been manually tested by creating as many different audit log changes as could be created in the API and then deserializing the past 100 entries. ([#1022] - [@zeylahellyer]). Changes Rename the `GuildCreate` audit log event to `GuildUpdate` ([#966] - [@zeylahellyer]). A few spelling errors have been fixed by adding the `codespell` Action ([#1041] - [@Gelbpunkt]. Fixes `PartialApplication` now uses `ApplicationFlags` instead of `UserFlags` ([#1072] - [@A5rocks]). [#966]: #966 [#1022]: #1022 [#1041]: #1041 [#1072]: #1072 [@A5rocks]: https://github.com/A5rocks [@Gelbpunkt]: https://github.com/Gelbpunkt [@zeylahellyer]: https://github.com/zeylahellyer
Erk-
pushed a commit
to Erk-/twilight
that referenced
this pull request
Aug 9, 2021
Fully support audit logs by creating types for Audit Log Changes and updating Audit Log Change Keys with new variants. Changes were generic `serde_value::Value`s, which provide no typed information. There are now variants with typed `new` and `old` values - checked against the API - which may or may not both always be present, or never. The `twilight_model::guild::audit_log` module is now entirely documented and tested as well. This has been manually tested by creating as many different audit log changes as could be created in the API and then deserializing the past 100 entries. Closes twilight-rs#77. Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully support audit logs by creating types for Audit Log Changes and updating Audit Log Change Keys with new variants. Changes were generic
serde_value::Values, which provide no typed information. There are now variants with typednewandoldvalues - checked against the API - which may or may not both always be present, or never.The
twilight_model::guild::audit_logmodule is now entirely documented and tested as well. This has been manually tested by creating as many different audit log changes as could be created in the API and then deserializing the past 100 entries.Closes #77.