Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin urllib3<2 #700

Merged
merged 2 commits into from
May 23, 2023
Merged

Pin urllib3<2 #700

merged 2 commits into from
May 23, 2023

Conversation

tristanlatr
Copy link
Contributor

I'll merge this PR right away to fix the tests and publish a bugfix release soon as well.

TODO: Create a ticket that summarizes the changes to be done when we'll drop support for python 3.6.

@tristanlatr tristanlatr linked an issue May 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3fdc421) 92.45% compared to head (1dc95f4) 92.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files          47       47           
  Lines        8056     8056           
  Branches     1925     1925           
=======================================
  Hits         7448     7448           
  Misses        354      354           
  Partials      254      254           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tristanlatr tristanlatr merged commit e01a24d into master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the urllib compatibility
1 participant