Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused wheel build dependency #629

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jul 31, 2024

Description

Remove the wheel dependency as it is not used anywhere. Hatchling does not use wheel (and setuptools either bundled it or pulled it in automatically).

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure local test run is green.
  • Create a file in src/towncrier/newsfragments/. Describe your
    change and include important information. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.
  • If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
  • If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@mgorny mgorny requested a review from a team as a code owner July 31, 2024 05:05
Remove the `wheel` dependency as it is not used anywhere.  Hatchling
does not use `wheel` (and setuptools either bundled it or pulled it
in automatically).
@hynek hynek enabled auto-merge (squash) July 31, 2024 06:26
@hynek hynek merged commit 11f9297 into twisted:trunk Jul 31, 2024
16 checks passed
@mgorny mgorny deleted the no-wheel branch July 31, 2024 06:42
@mgorny
Copy link
Contributor Author

mgorny commented Jul 31, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants