-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update coverage report to add inline PR comments. #451
Conversation
Codecov ReportBase: 100.00% // Head: 99.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## trunk #451 +/- ##
===========================================
- Coverage 100.00% 99.44% -0.56%
===========================================
Files 22 22
Lines 1607 1616 +9
Branches 286 288 +2
===========================================
Hits 1607 1607
- Misses 0 7 +7
- Partials 0 2 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
83a9401
to
64e9c0e
Compare
Diff CoverageDiff: origin/trunk...HEAD, staged and unstaged changes
Summary
src/towncrier/build.pyLines 119-130 click.echo("Finding news fragments...", err=to_err)
if directory == "sdfafsdfasd":
bla = "some line not covered"
# a comment
bla = "some line not covered"
bla = "some line not covered"
if config.directory is not None:
fragment_base_directory = os.path.abspath(config.directory)
fragment_directory = None Lines 134-146 )
fragment_directory = "newsfragments"
if directory == "sdfasdf":
bla = "some line not covered"
# a comment
bla = "some line not covered"
bla = "some line not covered"
fragment_directory = bla
fragment_contents, fragment_filenames = find_fragments(
fragment_base_directory,
config.sections, |
64e9c0e
to
5bd0965
Compare
5bd0965
to
7bb88f4
Compare
bla = "some line not covered" | ||
# a comment | ||
bla = "some line not covered" | ||
bla = "some line not covered" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing coverage.
f41363d
to
e847dc8
Compare
@@ -119,6 +119,12 @@ | |||
|
|||
click.echo("Finding news fragments...", err=to_err) | |||
|
|||
if directory == "sdfafsdfasd": | |||
bla = "some line not covered" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing coverage.
I tried to see how to use the GitHub Check Annotations, but it is not clear how to add annotations https://docs.github.com/en/rest/checks/runs#list-check-run-annotations At the same time, I think that we should not rely too much on GitHub Api. Instead, we should dedicated our time to improve the I am going to close this PR. |
Description
Fixes #450
Try to add inline comments for PR coverage
To make it easier to develop. I added some testing code for JS.
I guess that if all is ok, we can move it into a separate dedicated shared action.
In theory, we can convert this to Python code.