Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove FromIntLike typeclass. #554

Closed
johnynek opened this issue Oct 17, 2016 · 2 comments · Fixed by #594
Closed

remove FromIntLike typeclass. #554

johnynek opened this issue Oct 17, 2016 · 2 comments · Fixed by #594
Labels
beginner
Milestone
0.13.0

Comments

@johnynek
Copy link
Collaborator

this is in algebird-test, but really Ring[T] is enough and we never us it in a case where we don't have a Ring.
@johnynek
Copy link
Collaborator Author

in fact, when we merge #523 Ring already has this method.

@sritchie sritchie changed the title remove FromInt typeclass. remove FromIntLike typeclass. Oct 24, 2016
@sritchie sritchie added this to the 0.13.0 milestone Nov 29, 2016
@sritchie sritchie mentioned this issue Dec 3, 2016
Merged
@sritchie
Copy link
Collaborator

sritchie commented Dec 3, 2016

Closed by #594

@sritchie sritchie closed this as completed Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

replace FromIntLike with Ring and toK function twitter/algebird
2 participants
@johnynek @sritchie