Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in thrift ordered serialization macros #1528

Closed
johnynek opened this issue Feb 26, 2016 · 0 comments · Fixed by #1534
Closed

bug in thrift ordered serialization macros #1528

johnynek opened this issue Feb 26, 2016 · 0 comments · Fixed by #1534

Comments

@johnynek
Copy link
Collaborator

Got an error:

 found   : Option[Boolean]
 required: Option[String]

in generated code. Can't see the code in a compiled binary, so not sure what the deal is. Just don't want to forget.

I think we need more tests here to call this a success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Because, because... fun, the scala compiler has special naming rules … twitter/scalding
1 participant
@johnynek