Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

Use {request, response} format for normalizeFn to get consistency with scrubFn #1

Open
twolfson opened this issue Oct 28, 2016 · 2 comments

Comments

@twolfson
Copy link
Owner

Original issue: twolfson/nine-track-original-fork#1


If someone writes code for scrubFn and wants to move it to be used in normalizeFn or vice versa. It is requires a rewrite to be done. If we use the same signature, then we allow interchange easily.

@twolfson
Copy link
Owner Author

When we take this on, be sure to update eight-track-normalize-multipart.

@twolfson
Copy link
Owner Author

Another option to preserve backwards compatibility with plugins would be to move to (request, response) for function signature which is consistent with node's http. However, this is less consistent with our saved data.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant