You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The zigzag indicator implementation is great, however it's lacking in one key aspect.
There's no way to know when a pivot was actually detected. Currently, the zigzag can't be used for back-testing purposes, as the pivot indices are placed before their actual detection would have happened.
A column that shows at what bar index the pivot was confirmed would be fantastic. The column could either have the absolute index or an offset.
The text was updated successfully, but these errors were encountered:
I've decided to take a crack at the problem. Currently, I'm just adding commentary and making small adjustments for readability.
Should I make a PR when I've made these changes so it's more readable, in case other's want to try to implement it as well?
EDIT: I'll just make a PR
EDIT: PR has been made
The zigzag indicator implementation is great, however it's lacking in one key aspect.
There's no way to know when a pivot was actually detected. Currently, the zigzag can't be used for back-testing purposes, as the pivot indices are placed before their actual detection would have happened.
A column that shows at what bar index the pivot was confirmed would be fantastic. The column could either have the absolute index or an offset.
The text was updated successfully, but these errors were encountered: