Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigzag pivot detection index column #871

Open
80sVectorz opened this issue Jan 4, 2025 · 2 comments
Open

Zigzag pivot detection index column #871

80sVectorz opened this issue Jan 4, 2025 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@80sVectorz
Copy link

80sVectorz commented Jan 4, 2025

The zigzag indicator implementation is great, however it's lacking in one key aspect.
There's no way to know when a pivot was actually detected. Currently, the zigzag can't be used for back-testing purposes, as the pivot indices are placed before their actual detection would have happened.
A column that shows at what bar index the pivot was confirmed would be fantastic. The column could either have the absolute index or an offset.

@80sVectorz 80sVectorz added the enhancement New feature or request label Jan 4, 2025
@twopirllc twopirllc added the help wanted Extra attention is needed label Jan 5, 2025
@80sVectorz
Copy link
Author

80sVectorz commented Jan 6, 2025

I've decided to take a crack at the problem. Currently, I'm just adding commentary and making small adjustments for readability.
Should I make a PR when I've made these changes so it's more readable, in case other's want to try to implement it as well?
EDIT: I'll just make a PR
EDIT: PR has been made

@twopirllc
Copy link
Owner

Hello @80sVectorz

Yes PRs are more descriptive. Thanks for submitting one! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants