Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Gpu support in CLI needed #793

Closed
dPeS opened this issue Mar 29, 2018 · 5 comments
Closed

Gpu support in CLI needed #793

dPeS opened this issue Mar 29, 2018 · 5 comments

Comments

@dPeS
Copy link
Contributor

dPeS commented Mar 29, 2018

Hi,

When I added --gpus option here [1]:

cs submit --executor mesos --gpus 1 sleep 10
works ok (task is finished on gpu host), but:

[centos@ip-192-168-1-20]$ sudo cs submit --executor mesos --gpus 0 sleep 1
Attempting to submit on KKK cluster...
Job submission failed on KKK:
{"jobs": [{"gpus": "(not (pos? 0))"}]}
Job submission failed on all of your configured clusters.

any clues?

[1] https://github.com/twosigma/Cook/blob/master/cli/cook/subcommands/submit.py#L226

@dposada
Copy link
Contributor

dposada commented Mar 29, 2018

Hey @dPeS, thanks for the issue. The error you're getting is due to the fact that we have a server-side schema validation that doesn't allow gpus to be non-positive:

https://github.com/twosigma/Cook/blob/master/scheduler/src/cook/mesos/api.clj#L250

Can you leave off the --gpus flag altogether for the case where you don't need gpus?

@dPeS
Copy link
Contributor Author

dPeS commented Mar 29, 2018

Hi Daniel,

Sure I'm good here - that doesn't block me - just reporting.
Please remember to add --gpus option to submit.py

@dposada
Copy link
Contributor

dposada commented Mar 29, 2018

Sounds good. I will take a look at this. Glad to hear you're not blocked.

@dPeS
Copy link
Contributor Author

dPeS commented Apr 6, 2018

@dposada thanks, so I'm good here!

@dposada
Copy link
Contributor

dposada commented Apr 6, 2018

Resolved by PR #794

@dposada dposada closed this as completed Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants