feat: pallas byron #138
Merged
feat: pallas byron #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvcas
commented
Feb 8, 2022
src/sources/n2n/run.rs
Outdated
| @@ -62,6 +64,7 @@ impl Debug for Block2EventMapper { | |||
|
|
|||
| impl BlockObserver for Block2EventMapper { | |||
| fn on_block_received(&self, body: Vec<u8>) -> Result<(), Error> { | |||
| // byron::Block::decode_fragment(&body[..]); | |||
There was a problem hiding this comment.
@scarmuega is this where I would need to use the Byron cbor stuff?
|
@rvcas the latest commit adds to the n2n source the ability to handle Byron blocks and includes a placeholder for the entry point to start crawling through the inner structures.
I'll keep working on the above issue and on applying Byron logic to the n2c source. If you want to start working on the "crawling" of the block, you can do so in the |
|
@scarmuega thank you |
scarmuega
approved these changes
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm leaving this up for now as a work in progress