Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retry refactor #302

Merged
merged 3 commits into from
Jun 16, 2022
Merged

chore: retry refactor #302

merged 3 commits into from
Jun 16, 2022

Conversation

rvcas
Copy link
Member

@rvcas rvcas commented May 17, 2022

  • as discussed on discord this refactors the sinks gcp_pubsub and webhook to use the retry_operation util.

@rvcas rvcas requested a review from scarmuega as a code owner May 17, 2022 18:43
src/sinks/webhook/run.rs Outdated Show resolved Hide resolved
src/sinks/webhook/setup.rs Outdated Show resolved Hide resolved
scarmuega
scarmuega previously approved these changes May 17, 2022
@scarmuega
Copy link
Member

awesome!!

feat(sink/gcp_pubsub): use utils retry_operation

fix: remove async_recursion

feat: make retry_policy part of the configs

fix: max_backoff to 20x

feat: deserialize duration from milliseconds as a u64 in toml

feat: start gcp cloud functions

feat: add docs for cloud function and the retry policy

chore: update cargo toml feaure flags

chore: more docs
scarmuega
scarmuega previously approved these changes Jun 2, 2022
@scarmuega
Copy link
Member

amazing!

@scarmuega scarmuega merged commit dbf2798 into main Jun 16, 2022
@scarmuega scarmuega deleted the rvcas/retry_refactor branch June 16, 2022 00:46
kodemill pushed a commit to kodemill/oura that referenced this pull request Jun 24, 2022
Co-authored-by: Santiago Carmuega <santiago@carmuega.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants