-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: retry refactor #302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvcas
commented
May 17, 2022
scarmuega
reviewed
May 17, 2022
scarmuega
reviewed
May 17, 2022
rvcas
commented
May 17, 2022
scarmuega
previously approved these changes
May 17, 2022
awesome!! |
rvcas
force-pushed
the
rvcas/retry_refactor
branch
from
May 20, 2022 22:03
bdf862a
to
6fad310
Compare
rvcas
force-pushed
the
rvcas/retry_refactor
branch
from
May 30, 2022 22:34
6fad310
to
c87f4b6
Compare
feat(sink/gcp_pubsub): use utils retry_operation fix: remove async_recursion feat: make retry_policy part of the configs fix: max_backoff to 20x feat: deserialize duration from milliseconds as a u64 in toml feat: start gcp cloud functions feat: add docs for cloud function and the retry policy chore: update cargo toml feaure flags chore: more docs
rvcas
force-pushed
the
rvcas/retry_refactor
branch
from
May 31, 2022 00:15
14f20d6
to
7bd2274
Compare
scarmuega
previously approved these changes
Jun 2, 2022
amazing! |
scarmuega
approved these changes
Jun 16, 2022
kodemill
pushed a commit
to kodemill/oura
that referenced
this pull request
Jun 24, 2022
Co-authored-by: Santiago Carmuega <santiago@carmuega.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcp_pubsub
andwebhook
to use theretry_operation
util.