Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accommodate partial features build #333

Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix: Accommodate partial features build #333

merged 1 commit into from
Jun 21, 2022

Conversation

scarmuega
Copy link
Member

cargo build without any extra features was failing due to missing reqwest dep. This PR moves all web-related common logic into a module that get loaded only for required features.

@scarmuega scarmuega requested a review from rvcas June 21, 2022 00:18
@scarmuega scarmuega marked this pull request as ready for review June 21, 2022 00:20
@scarmuega scarmuega merged commit 5a946ac into main Jun 21, 2022
@scarmuega scarmuega deleted the fix/reqwest-dep branch June 21, 2022 00:24
kodemill pushed a commit to kodemill/oura that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant