added transaction size in TransactionRecord

[sumit2bk]

No description provided.

[scarmuega]

@sumit2bk thanks for this, it looks great. My only concern is that the CBOR encoding will probably have an impact in performance. Would be nice to hide this computation under a feature flag in configuration so that it's only enabled when needed (something similar to the include_transaction_details flag).

Would you be willing to add that as part of the PR? Otherwise, we can merge this one and treat the rest as a new PR.

[sumit2bk]

@sumit2bk thanks for this, it looks great. My only concern is that the CBOR encoding will probably have an impact in performance. Would be nice to hide this computation under a feature flag in configuration so that it's only enabled when needed (something similar to the include_transaction_details flag).

Would you be willing to add that as part of the PR? Otherwise, we can merge this one and treat the rest as a new PR.

Hi @scarmuega . The raw CBOR was available out of the box. I didn't have to do any encoding. Let me know if you think the flag is still needed and I can add it to the same PR.

[scarmuega]

@sumit2bk thanks for this, it looks great. My only concern is that the CBOR encoding will probably have an impact in performance. Would be nice to hide this computation under a feature flag in configuration so that it's only enabled when needed (something similar to the include_transaction_details flag).
Would you be willing to add that as part of the PR? Otherwise, we can merge this one and treat the rest as a new PR.

Hi @scarmuega . The raw CBOR was available out of the box. I didn't have to do any encoding. Let me know if you think the flag is still needed and I can add it to the same PR.

🤦 you're right, my bad. I forgot we already migrated to the version of Pallas that has the KeepRaw utility.

Great work!