Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Adding a BLOCK END line in the output for 'Terminal' sink #45

Closed
gitmachtl opened this issue Jan 9, 2022 · 2 comments · Fixed by #60
Closed

Feature Request: Adding a BLOCK END line in the output for 'Terminal' sink #45

gitmachtl opened this issue Jan 9, 2022 · 2 comments · Fixed by #60
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gitmachtl
Copy link

Would be nice to have some kind of a BLOCK END statement as the last output when tailing block data. A bit hard for the tools after the oura tail output (at least using the terminal sink) to react to the end of a block without the need to wait for the next one.

@gitmachtl gitmachtl changed the title Feature Request: Adding a BLOCK END line in the output Feature Request: Adding a BLOCK END line in the output for 'Terminal' sink Jan 9, 2022
@scarmuega scarmuega added the enhancement New feature or request label Jan 9, 2022
@scarmuega scarmuega moved this to Todo in Oura Development Jan 11, 2022
Repository owner moved this from Todo to Done in Oura Development Jan 13, 2022
@scarmuega
Copy link
Member

This change has been included in v1. This is an example of a "block end" event in the terminal sink output:

ENDBLK { slot: 50588072, hash: fa82daac103d61e2fa36887df9010457308a0a1f25534445e43dd73d92d14f5b, number: 6754845 }

It is also available in daemon but not enabled by default. It can be turned on by using the following config values:

[source.mapper]
include_block_end_events = true

@gitmachtl
Copy link
Author

thx! 😄

@mark-stopka mark-stopka added this to the v1.1 milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants