Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Please add the slot number to the BlockStart Message #52

Closed
gitmachtl opened this issue Jan 12, 2022 · 4 comments · Fixed by #59
Closed

Feature Request: Please add the slot number to the BlockStart Message #52

gitmachtl opened this issue Jan 12, 2022 · 4 comments · Fixed by #59
Labels
enhancement New feature or request

Comments

@gitmachtl
Copy link

Please include the slotNumber in the BlockStart Message like its included in the RollBack message:

Its included here:

BLOCK:------- █ TX:-- █ RLLBCK { slot: 50433895, hash: 38fdce5ade04818add867975d30980ae6330558f802ee2c04ed9173bf5ae21bb }

but not in the following "normal" BlockStart Messages:

BLOCK:6747699 █ TX:-- █ BLOCK  { hash: 38fdce5ade04818add867975d30980ae6330558f802ee2c04ed9173bf5ae21bb, body size: 72331, tx_count: 61, issuer vkey: 0e4a69e3af1e8edaa0cb75f3cf1856e4c27cdc739b0218a8fd5ab1a9a3e575ee, timestamp: 1642000167 }

Would be nice to have it like:

BLOCK:6747699 █ TX:-- █ BLOCK  { slot: 50433895, hash: 38fdce5ade04818add867975d30980ae6330558f802ee2c04ed9173bf5ae21bb, body size: 72331, tx_count: 61, issuer vkey: 0e4a69e3af1e8edaa0cb75f3cf1856e4c27cdc739b0218a8fd5ab1a9a3e575ee, timestamp: 1642000167 }
@mark-stopka mark-stopka added the enhancement New feature or request label Jan 13, 2022
@AndrewWestberg
Copy link

Can we prioritize this one? It's useful for tools monitoring Sundae scoopers.

@scarmuega
Copy link
Member

@AndrewWestberg will go out today with v1

@scarmuega
Copy link
Member

v1 release includes the changes for this issue. This is an example of the output of a block start event:

 { slot: 50587864, hash: ff15480d7299ca5510dc9f7f8a77773ae564f0d267357399f0d3abdcc8d23820, number: 6754838, body size: 45728, tx_count: 17, issuer vkey: 534972444c5983e1b8e3f563b6e4e60e2fac86fd1c258c455db8746dab31796b, ... }

@gitmachtl
Copy link
Author

thx! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants