Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(style): Add EditorConfig and relevant GH Action #91

Merged
merged 11 commits into from
Jan 25, 2022
Merged

Conversation

mark-stopka
Copy link
Collaborator

@mark-stopka mark-stopka commented Jan 24, 2022

Add EditorConfig and relevant GH Action to check compliance.

TODO:

  • Fix existing non-compliance

@mark-stopka mark-stopka self-assigned this Jan 24, 2022
scarmuega
scarmuega previously approved these changes Jan 24, 2022
@mark-stopka mark-stopka added automation enhancement New feature or request labels Jan 24, 2022
@mark-stopka mark-stopka added this to the v1.1 milestone Jan 24, 2022
@mark-stopka
Copy link
Collaborator Author

@scarmuega only .editorconfig needs to be checked, if it is up to your liking, upon merging and deploy of the gh-pages I will re-visit the mdBook Markdown files to see if I acciden tally broke anyting being unaware that Markdown uses two trailing_whitespace for newline; so I had trim_trailing_whitespace = true globally, that is now fixed for *.md files.

Lesson learned I guess =)

Copy link
Member

@scarmuega scarmuega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested a local run of the mdbook and it seems to work ok.

@scarmuega scarmuega merged commit 396e9e4 into main Jan 25, 2022
@scarmuega scarmuega deleted the ci/editorconfig branch January 25, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants