Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithdrawalRecord #349

Merged
merged 3 commits into from
Jul 23, 2022
Merged

WithdrawalRecord #349

merged 3 commits into from
Jul 23, 2022

Conversation

rvcas
Copy link
Member

@rvcas rvcas commented Jul 2, 2022

closes #345

@rvcas rvcas requested a review from scarmuega as a code owner July 2, 2022 04:08
scarmuega
scarmuega previously approved these changes Jul 2, 2022
@papacarp
Copy link
Contributor

papacarp commented Jul 4, 2022

Thank you for getting this in there! just one comment on this.

'withdrawals': [{'reward_account': 'e1512513037ed4d939e53189921f8ace4afdb34b1af5687ff8cafea277', 'coin': 2586673}]

The reward accounts (IE stake keys) usually drop the e1 and become a 56 character hex. As you can see in a delegation transaction the addrKeyHash is only 56 hex long. Should we drop the e1 for reward_accounts as well? I think the e1 is part of the cbor header for the field.

example delegation tx below:

{'context': {'block_hash': '1656ef779ebbd19b6d06e3998fbd170c6a7a0c144f81072a4df1841850b9dc65', 'block_number
': 7453870, 'slot': 65339733, 'timestamp': 1656906024, 'tx_idx': 11, 'tx_hash': 'baa2128cd25120ca91e5aa58f1a
c4fc9e013b4b3bd9d00d3fb63146d51141de9', 'input_idx': None, 'output_idx': None, 'output_address': None, 'cert
ificate_idx': 1}, 'stake_delegation': {'credential': {'AddrKeyhash': 'ff4fe21daff03387be90477e0d3cd695dea94f
739a088079d8182422'}, 'pool_hash': 'e4abcf4408584601e7c707a8902996c0c291e1a3c8300b327ae3f6ab'}, 'fingerprint
': '65339733.dele.275927461906885510568945705003751848297', 'variant': 'StakeDelegation', 'timestamp': 16569
06024000}

@rvcas rvcas merged commit 44cacbe into main Jul 23, 2022
@rvcas rvcas deleted the rvcas/reward_withdrawls branch July 23, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reward withdrawals to transaction data
3 participants