Small tweaks and addressing some warnings on tychedelia's awesome work in #940 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
approved these changes
Jan 17, 2024
| @@ -82,7 +82,7 @@ pub struct Renderer { | |||
| glyph_cache_texture: wgpu::Texture, | |||
| depth_texture: wgpu::Texture, | |||
| depth_texture_view: wgpu::TextureView, | |||
| default_texture: wgpu::Texture, | |||
| _default_texture: wgpu::Texture, | |||
There was a problem hiding this comment.
probably should just be removed?
There was a problem hiding this comment.
Yeah I was thinking this, though I couldn't quite recall if we had to keep them in memory and if their behaviour changes if they're dropped earlier e.g. 🤔 I guess we wouldn't get these warnings if they had a Drop implementation? But I'm not 100% certain of that 😅
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title mentions, just some small tweaks and addressing some warnings for https://github.com/nannou-org/nannou/pull/940/files. cc @tychedelia