-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Token Scopes not provided #601
Comments
Actually not sure if this would be a glint concern or an ember language server concern. I'm tracking an issue related to code folding on ELS here lifeart/vscode-ember#43 and if the fix for code folding is for ELS to provide JS/TS folding, the fix for semantic tokens might also be to add it to ELS. Since the typescript language server is not running for a |
I think adding semantic folding here makes sense as well, at the very least for the js/ts stuff. To do the in- |
Semantic tokens add additional syntax highlighting for things like decorators etc.
Also tracking in chiragpat/vscode-glimmer#14
When this is used with
vscode-glimmer
, I don't think the language server provides thesemanticTokenScopes
required to apply the correct colours ontop of the syntax highlighting.Typescript Language Server provides semantic tokens here https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/src/languageFeatures/semanticTokens.ts
The text was updated successfully, but these errors were encountered: