Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate interruptible(boolean) and replace with interruptible/interruptibleMany #2268

Closed
djspiewak opened this issue Aug 27, 2021 Discussed in #2248 · 2 comments · Fixed by #2343
Closed

Deprecate interruptible(boolean) and replace with interruptible/interruptibleMany #2268

djspiewak opened this issue Aug 27, 2021 Discussed in #2248 · 2 comments · Fixed by #2343
Assignees
Milestone

Comments

@djspiewak
Copy link
Member

By "deprecate" I mean "set to private[effect] and undo the currying". We need to maintain binary compatibility but we can break source compatibility with this change. The goal should be for IO.interruptible(...) to be equivalent to what IO.interruptible(false)(...) is today, while IO.interruptibleMany(...) should be equivalent to IO.interruptible(true)(...). This change should also be applied to Sync.

Discussed in #2248

Originally posted by etspaceman August 19, 2021
I'm wondering if we should create an alias around this. For example, interruptible(false) reads like it isn't interruptible. Perhaps we should consider interruptibleOnce and interruptibleMany.

@djspiewak djspiewak added this to the v3.3.0 milestone Aug 30, 2021
@alexandrustana
Copy link
Contributor

I could pick this up if nobody minds.

@djspiewak
Copy link
Member Author

Go for it! The only tricky part will be pleasing binary compatibility while you go about it. Always feel free to ask questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants