Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add something like Foldable1 / Traverse1 ? #145

Closed
aryairani opened this issue Feb 9, 2015 · 3 comments
Closed

Add something like Foldable1 / Traverse1 ? #145

aryairani opened this issue Feb 9, 2015 · 3 comments

Comments

@aryairani
Copy link
Contributor

These are nice.

@non
Copy link
Contributor

non commented Feb 9, 2015

I think instead of Foldable1 we should call it Reducible to parallel the relationship between foldLeft and reduceLeft.

@ceedubs
Copy link
Contributor

ceedubs commented Apr 23, 2015

I definitely would like to see these type classes.

I do like that Reducible would draw a parallel between foldLeft and reduceLeft. However, in the grand scheme of things, I'm wondering if Foldable1 would be more consistent/clear. Assuming we would have Traverse1/Traverse, the relationship between Foldable1/Foldable might be more clear. We have already chosen to use MonoidK and SemigroupK instead of the scalaz names to express their relationships with Monoid/Semigroup (respectively).

Also people hopefully have a fear of std lib's reduceLeft since it blows up on empty collections ;)

@non
Copy link
Contributor

non commented May 22, 2015

Fixed in #298.

@non non closed this as completed May 22, 2015
@xuwei-k xuwei-k mentioned this issue Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants