-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Semigroupal
from Arrow
for free
#2069
Comments
Would this be a binary compatible change? |
I think so. |
A relevant question would be whether there are conceivable |
@ceedubs are you suggesting making it explicit? |
@kailuowang that was one thought that I had. But I don't know if there's really any reason to that. Just my usual paranoia :). I'll ponder this a bit and give others a chance to weigh in over the next day or two, and if nobody can think of a reason that this implicit def shouldn't exist, then maybe it's either good or mostly harmless. |
I can open a PR for this. I think you can reasonably strengthen it to |
Fixed by #2078 |
We could add the following to
Semigroupal
's companion#2063 is adding a
merge
method, so this instance can just delegate to that.To test this we might need to create a new
case class MyFunc[A, B](f: A => B)
and anArrow
instance for it and then test the Semigroupal laws against it.I set the milestone to be 1.1, but it can certainly be done by 1.0
The text was updated successfully, but these errors were encountered: