Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross build for Scala.js 0.6.x and 1.x #2195

Closed
ghost opened this issue Mar 15, 2018 · 10 comments
Closed

Cross build for Scala.js 0.6.x and 1.x #2195

ghost opened this issue Mar 15, 2018 · 10 comments

Comments

@ghost
Copy link

ghost commented Mar 15, 2018

see https://www.scala-js.org/news/2018/02/01/announcing-scalajs-1.0.0-M3/, esp the tips on cross-building.

Also of interest may be sbt-dynscalajs, but read the disclaimers first.

This task may be worth doing in conjunction #1549 as there are (potentially) some overlaps with the new cross project setup

@kailuowang
Copy link
Contributor

kailuowang commented Mar 15, 2018

maybe we should consider adding this support to sbt-catalysts and start using it in cats?

@ghost
Copy link
Author

ghost commented May 23, 2018

Quick update on this:

This change requires the change to the newer crossproject. Coupled with that, I recently did a PR for SBT that introduces composite projects - see sbt/sbt#3042 and sbt/sbt#4056

So I'm waiting for sbt 1.2, that hopefully will be out soon

@randm-ch
Copy link

randm-ch commented Jul 7, 2018

@BennyHill SBT 1.2.0-M1 is out :) Any ETA on this or are you waiting for the full release?

@ghost
Copy link
Author

ghost commented Jul 7, 2018

@randm-ch Also required is the new crossproject to use this, but looks like that work is done already - portable-scala/sbt-crossproject#99.

So nothing holding back on moving this forward now... but I'm away on holiday for another week.

But the tentative release for sbt 1.2 is only 16th July, not far way in any case

@ghost
Copy link
Author

ghost commented Jul 7, 2018

However, in #2267 @djspiewak notes that sbt-crossbuild is required for 2.13.X, so I'm wondering if it may be better/quicker/easier to split the task up to:

In Parallel:

  • update catalaysts build to use sbt-crossproject, leave everything else as-is (N.B. this requires sbt-catalysts changes)
  • update cats build to use sbt-crossproject, leave everything else as-is

Then:

  • update update catalysts build to use sbt 1.2 and new CI sbt-crossproject, At this point we can see how easy/difficult it is to either migrate cats to sbt-catalysts OR manually update cats build to cross compile with scala-js

My main concern/goal would be to "show" to cats, and derivative projects such as cats-effects, that we can increase the build matrix AND make it simpler, as I think there is currently some general concern that all this cross-building is a pain

@ghost
Copy link
Author

ghost commented Jul 15, 2018

Status/fyi :

update cats build to use sbt-crossproject, leave everything else as-is

See pr #2323

@randm-ch
Copy link

@kailuowang would you mind taking a look at this issue? Sounds like everything's ready, but the original assignee became a ghost 😉

@s5bug
Copy link
Contributor

s5bug commented Aug 18, 2019

Any update on this? Scala.JS 1.x has some features I require for a project, and I'd like to be using fs2 for it.

@psttf
Copy link

psttf commented Jun 5, 2020

Can this issue be closed now?

@djspiewak
Copy link
Member

Most definitely. Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants