Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const should have a CommutativeApply/CommutativeApplicative instance #2201

Closed
LukaJCB opened this issue Mar 19, 2018 · 4 comments
Closed

Const should have a CommutativeApply/CommutativeApplicative instance #2201

LukaJCB opened this issue Mar 19, 2018 · 4 comments
Labels
help wanted low-hanging fruit

Comments

@LukaJCB
Copy link
Member

LukaJCB commented Mar 19, 2018

Whenever C has a CommutativeSemigroup/Monoid instance. We should be able to add these in a backwards compatible way, no?
@kailuowang
Copy link
Contributor

Yes. Adding instances is usually binary compatible in cats. I went through all of the instance definitions to make sure they are abstract classes before the 1.0 release.

@barambani
Copy link
Contributor

it should be pretty similar to the stuff I've looked into recently. I would try it if that's ok

@LukaJCB
Copy link
Member Author

LukaJCB commented Mar 19, 2018

That'd be great thanks!

@barambani barambani mentioned this issue Mar 20, 2018
Merged
@ceedubs
Copy link
Contributor

ceedubs commented Mar 24, 2018

Resolved by #2204

@ceedubs ceedubs closed this as completed Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted low-hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kailuowang @barambani @ceedubs @LukaJCB