Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scalacheck to 1.14.0 #2449

Closed
avdv opened this issue Aug 31, 2018 · 5 comments
Closed

Upgrade scalacheck to 1.14.0 #2449

avdv opened this issue Aug 31, 2018 · 5 comments
Milestone

Comments

@avdv
Copy link

avdv commented Aug 31, 2018

I am using specs2 4.3.x and I want to use cats-laws with it.

Unfortunately, specs2-scalacheck >= 4.2.0 requires scalacheck 1.14.0 but cats-laws 1.2.0 is build with scalacheck 1.13.5 which is binary incompatible with each other.

This results in the following runtime exception:

[error] cannot create an instance for class com.rub.models.resources.ParamSpec
[error]   caused by java.lang.NoSuchMethodError: org.scalacheck.Cogen$.apply(Lorg/scalacheck/Cogen;Lorg/scalacheck/Cogen;)Lorg/scalacheck/Cogen;
[error]   sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
[error]   sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
[error]   sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
[error]   java.lang.reflect.Constructor.newInstance(Constructor.java:423)
[error]   org.specs2.reflect.Classes.$anonfun$createInstanceForConstructor$1(Classes.scala:69)
[error]   org.specs2.reflect.Classes.newInstance(Classes.scala:91)
@johnynek
Copy link
Contributor

We can't do that until we break binary compatibility (cats 3.0 is our current plan, cats 2.0 will be binary compatible for scala 2.12, but not 2.11). scalacheck should ideally be using mima, and they should have bumped to scalacheck 2.0.0.

cc @non

@ceedubs ceedubs added this to the 3.0 milestone Aug 31, 2018
@SethTisue
Copy link
Member

is it necessary for the bincompat guarantees to extend even to test-only dependencies...? (I'm genuinely asking, not expressing an opinion)

@rossabaker
Copy link
Member

There is a deeper discussion of this on #2312 with a possible solution for cats-1.x.

@johnynek
Copy link
Contributor

@SethTisue cats-laws is not test-only, for that artifact, scalacheck is a regular dependency.

@kailuowang
Copy link
Contributor

This has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants