Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash[SortedSet[A]]'s constraint seems too strong #3038

Closed
travisbrown opened this issue Sep 8, 2019 · 2 comments
Closed

Hash[SortedSet[A]]'s constraint seems too strong #3038

travisbrown opened this issue Sep 8, 2019 · 2 comments
Labels
bug

Comments

@travisbrown
Copy link
Contributor

Right now we have the following:

  implicit def catsKernelStdHashForSortedSet[A: Order: Hash]: Hash[SortedSet[A]] =
    new SortedSetHash[A]

I don't think we need A: Order here, just A: Hash (which implies A: Eq).
@travisbrown travisbrown added the bug label Sep 8, 2019
@travisbrown travisbrown mentioned this issue Sep 8, 2019
Closed
@tnielens
Copy link
Contributor

tnielens commented Apr 9, 2021

This was already implemented:

cats/kernel/src/main/scala/cats/kernel/instances/SortedSetInstances.scala

Line 11 in 9753b34

implicit def catsKernelStdHashForSortedSet[A: Hash]: Hash[SortedSet[A]] =

@rossabaker
Copy link
Member

Yep. Thanks for the nudge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rossabaker @travisbrown @tnielens