Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future instances not in implicit scope #3536

Closed
mrdziuban opened this issue Jul 28, 2020 · 4 comments
Closed

Future instances not in implicit scope #3536

mrdziuban opened this issue Jul 28, 2020 · 4 comments
Labels

Comments

@mrdziuban
Copy link
Contributor

Importing cats.instances.future._ is still required to summon typeclass instances for scala.concurrent.Future, e.g.

import cats.Applicative
import scala.concurrent.Future
import scala.concurrent.ExecutionContext.Implicits.global

Applicative[Future]
// Could not find an instance of Applicative for scala.concurrent.Future

import cats.instances.future._

Applicative[Future]
// cats.Applicative[concurrent.Future] = cats.instances.FutureInstances$$anon$1@479111ba

This was the only cats.instances import I needed to keep around when upgrading a large codebase that strictly uses a la carte imports from v2.1.1 to v2.2.0-RC2.

@LukaJCB LukaJCB added the bug label Jul 28, 2020
@LukaJCB
Copy link
Member

LukaJCB commented Jul 28, 2020

Thanks for bringing this up! Will have a look soon

@travisbrown
Copy link
Contributor

I believe there was some discussion about this somewhere, and that excluding them was a design decision, but I don't remember the details, and I'm not committed to either including or excluding them from implicit scope.

@barambani
Copy link
Contributor

This #2334 may or may not be what @travisbrown is referring to, but I'm adding it here for reference as that discussion is still open and marked for milestone 3.0

@barambani
Copy link
Contributor

Referencing relevant discussion here #3566 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants