-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: merge cats-time
into cats
#3766
Comments
Since cats already requires Java 8+ as of version 2.1.0 because it's only published for Scala 2.12+, I think this proposal is very sensible |
The only major concern here would be around ScalaJS support. |
In other projects there is a separation of sources that are JS-specific or JVM-specific. Perhaps we can do the same here? |
Strong 👍. We shouldn't accept a lesser experience on our flagship platform when a feature is not supported by a secondary platform. And for the Java 8 requirement, public support for Java 7 ended in 2015. |
Taking existing support into account, I have opened PR to integrate this into the |
cats-time
is a microlibrary that implements instances of kernel typeclasses, such asShow
,Ord
,Eq
, orHash
, for the classes of thejava.time
package. This package was introduced in version 8.0 of the JDK, in order to replace previous unsatisfactory classes (such asjava.Date
), and was derived fromjoda-time
.The proposal is that these files be merged into the
kernel
package, and thecats-time
library archived.Some considerations on this matter are as follows:
java.util.UUID
already inkernel
.java.time
is just as standard a library asOption
,Either
, so it is reasonable to also include its instances in the package.cats
and the JVM platform specifically, but as mentioned that already happens withjava.util.UUID
.cats
kernel incompatible with JDK pre-8 versions. The existing instance forUUID
only adds incompatibility with pre-1.5 JDKs. Note that JDK 8 was released in March 2014, almost seven years ago, so I am not sure how farcats
retrocompatibility should go.The text was updated successfully, but these errors were encountered: